add special case for Norwegian Bokmål #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a bit ugly special case but istuation itself is also an ugly special case fixes streetcomplete#3890
|
Confirmed as a good idea by #3890 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a bit ugly special case but istuation itself is also an ugly special case
fixes #3890
I investigated is Bokmål affected also elsewhere and found no evidence of that - I found only that it is listed twice in language selection list (once as Norwegian, once as Norwegian Bokmål) - and I am not really sure is it even a bug.
I also looked for a similar problematic cases and found no issues.
Still, likely that I missed something and something else is affected or it should be changed in a different way as it seems quite ugly hack.