Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show local ref where present along with names #3903

Merged
merged 3 commits into from
Mar 22, 2022

Conversation

peternewman
Copy link
Collaborator

@peternewman peternewman commented Mar 21, 2022

E.g. for bus stops

Fixes #3800

@kmpoppe
Copy link
Contributor

kmpoppe commented Mar 21, 2022

Solution for #3800 ?

@peternewman peternewman changed the title Show local ref where present along with names Show local ref where present along with names closes #3800 Mar 21, 2022
@peternewman

This comment was marked as off-topic.

@kmpoppe

This comment was marked as off-topic.

@FloEdelmann

This comment was marked as off-topic.

@FloEdelmann FloEdelmann changed the title Show local ref where present along with names closes #3800 Show local ref where present along with names Mar 21, 2022
@westnordost
Copy link
Member

So local_ref should only be shown if there is a name? Could you please post some rationale for that?

I.e.

  1. why with name and not with operator?
  2. why not if neither name (nor operator) is available

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Mar 21, 2022
@peternewman
Copy link
Collaborator Author

So local_ref should only be shown if there is a name? Could you please post some rationale for that?

I was just trying to change the bare minimum for the moment.

Given you didn't want house numbers shown if a name existed elsewhere, I was sticking to the same idea).

Personally I'm only aware of bus stops where it would add value for me.

I.e.

1. why with name and not with operator?

We could do it there too.

2. why not if neither name (nor operator) is available

I've added it, in theory in the bus stop case it could result in just "B" being shown, unless we want to try and translate strings for both ref and local ref and use them?

@westnordost
Copy link
Member

You put local_ref into parenthesis but ref isn't. Is this deliberate?

@peternewman
Copy link
Collaborator Author

In my experience the local_ref is normally one or two characters, whereas ref is often longer (as it will be unique per country potentially) so I was just trying to differentiate the two types of ref and make it less likely people think there is a typo in the name (e.g. Euston Station C.

@westnordost
Copy link
Member

Then maybe for consistency have parenthesis for ref tooLooking at taginfo, mostref` seem to be single or two letters too

@peternewman
Copy link
Collaborator Author

Then maybe for consistency have parenthesis for ref too`

Done, I've taken the liberty of using square brackets to differentiate from localref. It shouldn't make much difference to average users, but would allow any power users to leave a note if something isn't using the expected tagging (e.g. if a post box or bus stop has used local_ref rather than ref).

Looking at taginfo, mostref seem to be single or two letters too

The subtlety might be which tags they're used in combination with, and whether they're actually likely to appear on SC.

@westnordost
Copy link
Member

Done, I've taken the liberty of using square brackets to differentiate from localref. It shouldn't make much difference to average users, but would allow any power users to leave a note if something isn't using the expected tagging

I don't like it. For every special UI quirk for one power user, there'll be 10 normal users that are potentially confused by it. But anyway, I don't not like it enough to require you to change this for this to be merged.

@westnordost westnordost merged commit 1d0e491 into streetcomplete:master Mar 22, 2022
FloEdelmann added a commit that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback required more info is needed, issue will be likely closed if it is not provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants