Patch SnakeYAML dependency #3914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, cool! That works? So easy! Thank you for your effort! I don't have an Android 5 around anymore (lent it to @mr-elbe5) but I'll try to reproduce it with an Android 5 emulator |
westnordost
reviewed
Mar 24, 2022
|
The issue is reproducable on an Android 5 emulator and I can confirm that this solves the issue on an Android 5 emulator. 👍 |
|
Yay! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3889.
Running
../gradlew dependenciesin theappdirectory verifies that all occurrences oforg.snakeyaml:snakeyaml-engineare indeed replaced with the patchedorg.bitbucket.snakeyaml:snakeyaml-engine:8209bb9484version from https://jitpack.io/#org.bitbucket.snakeyaml.snakeyaml-engine.src.master/This compiles and works fine in the emulator with Android 11. @westnordost can you try to reproduce the issue in Android 5?