Check shop existence #4843
Merged
Check shop existence #4843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes streetcomplete#4232 opening hours quest acts as a de facto checker of shop existence, but some people disabled it. separate from CheckExistence as very old shop with opening hours should show opening hours resurvey quest rather than this one (which would cause edit date to be changed and silence all resurvey quests)
FloEdelmann
reviewed
Feb 25, 2023
app/src/main/java/de/westnordost/streetcomplete/quests/shop_type/CheckShopExistenceForm.kt
Outdated
Show resolved
Hide resolved
FloEdelmann
reviewed
Feb 25, 2023
app/src/main/java/de/westnordost/streetcomplete/quests/shop_type/CheckShopExistenceForm.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
westnordost
reviewed
Feb 25, 2023
app/src/main/java/de/westnordost/streetcomplete/quests/shop_type/CheckShopExistence.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/shop_type/CheckShopExistence.kt
Outdated
Show resolved
Hide resolved
Yeah, added for chance to implement something not growing into megaproject :) |
|
I'll approve this but not merge it yet because it is a new feature (albeit it does not require new strings). |
westnordost
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4232
Seems OK and plan on merging if noone will have feedback about this, but I want to give chance to review. No new text is being used here.
Why as a separate quest? Check existence quest is before opening hours, wheelchair quest and so on.
This one should be after opening hours etc, otherwise they would not be resurveyed in some cases. For example if check existence AND opening hours quests are enabled AND shop has
opening_hourstagged AND shop node was not edited for 13 years, then opening hours resurvey quest should be asked, not check existence quest.Otherwise user would confirm existence, what would update object and opening hours resurvey would not be asked.
And why it is useful at all if opening hours already acts as a de facto existence checker? OH is quite time-consuming and some people could disable it without enabling wheelchair quest or similar.