Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hairdresser quest #4909

Merged
merged 11 commits into from May 2, 2023
Merged

Conversation

mnalis
Copy link
Member

@mnalis mnalis commented Mar 29, 2023

Closes: #4833

TODO:

  • Discuss: does it need resurvey?
  • Discuss: better English for question than "What are the signed customers of this hairdresser?" ? Perhaps "Which customers are indicated on the sign for this hairdresser?" ?
  • verify that everything works
    yes, debug APK at https://github.com/mnalis/StreetComplete/actions/runs/4600306640
  • uses icon made from existing scissors.svg

@mnalis

This comment was marked as resolved.

@mnalis mnalis added the help wanted help by contributors is appreciated; might be a good first contribution for first-timers label Mar 29, 2023
@westnordost
Copy link
Member

I think it does not need resurvey.

For the icon, you can just use scissors. There is already a scissors SVG in the resources, you can reuse that.

@mnalis

This comment was marked as resolved.

@westnordost
Copy link
Member

westnordost commented Mar 30, 2023 via email

@mnalis
Copy link
Member Author

mnalis commented Mar 30, 2023

I think it should be Somerton along the lines of "for whom is hairdresser?"

OK. ChatGPT however says 😺 :

While the phrase "For whom is this hairdresser?" may be technically correct grammatically, it does not sound natural or idiomatic in English. A more natural way to ask this question would be "Who does this hairdresser serve?" or "Which customers does this hairdresser provide services for?"

And gives more alternatives, of which I've settled for short and simple "Which customers visit this hairdresser?"

Unless someone feels the need to suggest something better, I'll mark this PR as ready tomorrow.

@mnalis mnalis marked this pull request as ready for review March 31, 2023 13:41
@westnordost westnordost removed the help wanted help by contributors is appreciated; might be a good first contribution for first-timers label Apr 2, 2023
@westnordost
Copy link
Member

I understand that you wanted to create an issue or (better) a PR over at the iD tagging schema repo if the way how iD tags it conflicts with this quest?

@mnalis
Copy link
Member Author

mnalis commented Apr 14, 2023

I understand that you wanted to create an issue or (better) a PR over at the iD tagging schema repo if the way how iD tags it conflicts with this quest?

Yes, I'm wading through existing iD gender issues currently, so I have background and can reference them in new issue (or contribute to existing one with same problem, if present)

iD uses radio button so only one of fields male / female / unisex can be selected, but it does indicate by background color when multiple (e.g. male+female) are selected:

mf2

So while not actually conflicting, it definitely does not handle it in the best possible way...

@mnalis
Copy link
Member Author

mnalis commented Apr 19, 2023

While iD does show multiple gender tags, it does it in subtle way that is (IMHO) somewhat likely to be missed by its users.

The suggestion for UI improvement (i.e. use checkboxes instead of radiobuttons, like JOSM and Vespucci do) has been suggested at openstreetmap/id-tagging-schema#894

@westnordost westnordost merged commit 14519b7 into streetcomplete:master May 2, 2023
@mnalis mnalis deleted the hairdresser-quest branch May 3, 2023 02:44
@amandasaurus
Copy link

I agree about not using “whom”. Many people who learn English as a second language, use “whom” because in the past that was Proper Grammer™, however it sounds very old fashioned, and unnatural.

And gives more alternatives, of which I've settled for short and simple "Which customers visit this hairdresser?"

A problem with this is that it refers to the type of customers, which regular visit that place. Someone standing on the street, can't know what happens regularly, they can only look at the sign. They cannot know the regular occurances.

I think “Who is this hairdresser for?” (while showing the gender options) is pretty clear & better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quest suggestion: hairdresser for men/women/all
3 participants