Tactile steps #5003
Merged
Tactile steps #5003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/de/westnordost/streetcomplete/quests/QuestsModule.kt # app/src/main/res/values/strings.xml
westnordost
reviewed
May 7, 2023
app/src/main/java/de/westnordost/streetcomplete/quests/tactile_paving/AddTactilePavingSteps.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/tactile_paving/AddTactilePavingSteps.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Tobias Zwick <newton@westnordost.de>
westnordost
approved these changes
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3534 now that it is not marked as blocked, follows on from work in #3762
Again, my first attempt at an icon (combining tactile paving and steps icons)
There are three new strings here as the current string for incorrect tactile paving is "Only on one side" and this doesn't make sense for steps, so it needed at least a string "Only at one end" and to me it makes sense to have separate options for top and bottom.
Tested and working and tests all pass