Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Quest: Does this caravan area have a sanitary_dump_station? #5363

Merged
merged 17 commits into from Nov 26, 2023

Conversation

qugebert
Copy link
Contributor

@qugebert qugebert commented Nov 6, 2023

Closes #5233

Screenshot_20231106-144822

qugebert and others added 2 commits November 6, 2023 15:09
…y_dump_station/AddSanitaryDumpStation.kt

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
@westnordost
Copy link
Member

The pictures for the different resolutions all have the same resolution.

But apart from this, I am really not sure if these pictures are that helpful. When not looking (very) closely, they just look like photos of a generic motorway lay-by with some signs.

What do we have? We have

  • a question that mentions the keyword "sanitary dump station" - most important
  • a description that explains what a "sanitary dump station" is - also important, because there may be synonyms
  • a quest icon that imitates how the sign for this may look like (in France)

So, to me, the photos do not add a value, because (very tiny) you see the same sign again, and for the right picture, I don't even know where the sanitary dump station is supposed to be.

Realisticially, such a facility would either be indicated by name, or by a well-known sign with an icon. So, what is missing to make sure that a surveyor with 0 knowledge about this can ascertain whether a place like this exists, is to show him how (else) this facility could be indicated, not some photos of how the place in general would look like.

Not sure if there is a an official Vienna-convention sign for this, if there is, this should be shown instead. Just like it is done for example in the maxspeed quest when the user selects that it is a living street, see here:
https://github.com/streetcomplete/StreetComplete/tree/master/res/graphics/living%20street

If no standardization exists, then might as well leave out the picture because not sure if showing many variations of how it may look like would be too helpful.

@qugebert
Copy link
Contributor Author

qugebert commented Nov 7, 2023

Ok, so i can remove the image, just added this because of the comments in the issue that we need further explanation. I have no idea how we can make a better hint, but i asked the issue author.

@westnordost
Copy link
Member

westnordost commented Nov 7, 2023

Well, as done for the maxspeed quests, certainly a picture could be helpful, but it should show (an) example(s) of how the sanitary dump station is indicated, not how it generally looks like.

https://www.google.de/search?q=%22sanitary+dump+station%22+sign&tbm=isch

If there is no standard, it may make sense to create an icon that is generic and similar enough to any national / regional standard that it can be recognized.

(This is the reason why I created the graphics in https://github.com/streetcomplete/StreetComplete/tree/master/res/graphics/living%20street myself, because each is a simplification of the design - otherwise there would have to be individual graphics for each different country as in each different country, it looks slightly different)

@qugebert
Copy link
Contributor Author

Ok, so like this?
Screenshot_20231110-155744

@westnordost
Copy link
Member

westnordost commented Nov 10, 2023

Hm, two times basically the same sign, a bit German(?)-centric. But that's okay, I might draw up some own icons myself after merge. (I wanted to do that for the quest icon anyway, as it is not so consistent with the style of other quest icons (too monochrome, too fine details).

@mcliquid
Copy link
Contributor

@qugebert The two variants were intended more as "either A or B", not both at the same time 😄 I would take the right / blue-filled one, as the visibility is better there.

@qugebert
Copy link
Contributor Author

Sorry, ich habe überhaupt keinen Sinn für gute Grafiken / Design.
Ich könnte das hier noch als zweites Schild anbieten (eben selbst in Inkscape skizziert, angelehnt an Ergebnisse aus der Bildersuche), ansonsten würde ichs euch überlassen.

rect1510-7

@mcliquid
Copy link
Contributor

Ich würde den Text weglassen, da den sonst (theoretisch) in der Grafik in alle verfügbaren Sprachen übersetzen müsste. Die Grafik sagt auch ohne Text genug aus.
In der Regel haben Wohnwägen auch nicht einen solch großen Radabstand 👀

@qugebert
Copy link
Contributor Author

qugebert commented Nov 10, 2023

Stimmt, das mit der Übersetzung hatte ich nicht bedacht, ich lasse den Text weg.
Ich habe diese Version mal mit abgelegt (hier), wenn du willst passe es gerne noch an oder nehmt was komplett anderes, ich kann so etwas wie gesagt einfach schlecht einschätzen.

@FloEdelmann FloEdelmann added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label Nov 16, 2023
@westnordost
Copy link
Member

So today I set out to draw some nicer generalized signs than shown in the last screenshot, including something like the brown sign, only to find out that you already changed the picture to include the brown sign.

Anyway, I think my redrawings are still a bit of an improvement, at least they fit the graphics style of the app more

@qugebert
Copy link
Contributor Author

Dankeschön :)

@westnordost westnordost merged commit 9de3369 into streetcomplete:master Nov 26, 2023
@qugebert qugebert deleted the sanitary_dump_station branch December 4, 2023 19:14
@sun-geo
Copy link
Contributor

sun-geo commented Dec 19, 2023

Thank you for the new quest.

Please update the query under:
https://github.com/streetcomplete/StreetComplete/blob/master/app/src/main/java/de/westnordost/streetcomplete/quests/sanitary_dump_station/AddSanitaryDumpStation.kt
line 17:
from:
or tourism = camping_site and caravans = yes and !backcountry
to:
or tourism = camp_site and caravans = yes and !backcountry

In the wiki there is only
https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dcamp_site
available.

@FloEdelmann
Copy link
Member

Thanks for finding this @sun-geo! Would you like to update this yourself and send a pull request?

@sun-geo
Copy link
Contributor

sun-geo commented Dec 19, 2023

I updated it, see request: #5407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does this caravan area have a sanitary_dump_station ?
5 participants