Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ask payment methods if payment:others=no is set #5589

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

urbalazs
Copy link
Contributor

The wiki says that payment:others=no can be used if you have already indicated all methods of payment which are accepted. Do not need to ask whether cash or cards are accepted if this key is set.

@mnalis
Copy link
Member

mnalis commented Apr 21, 2024

Make sense, although one should add checks for no value explicitly (there are few percent of other values for payment:others, like yes)

@Helium314
Copy link
Collaborator

Shouldn't yes mean that all other methods are accepted? (doesn't sound like something that could actually be correct though)

Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, makese sense! As per the comments above, the filter should be payment:others != no though.

@urbalazs
Copy link
Contributor Author

I added only the key without value because

  • payment:others=no means that no need to ask if missing cash or card method is needed since others is no
  • payment:others=yes means that no need to ask if missing cash or card method is needed since others is yes - I know that this makes no sense, but StreetComplete is not a validator to decide whether a tag makes sense or not
  • missing payment:others=* means that SC should ask if missing cash or card can be accepted

@westnordost
Copy link
Member

westnordost commented Apr 21, 2024

I think yes is the opposite of no, so it means "yes, there are other payment methods that may be accepted" (or in other words: the payment-list provided is not exhaustive) rather than "yes, ANY other payment method imaginable is accepted". As you and Helium314 noted, the latter would make no sense.

@westnordost westnordost merged commit 4e7f926 into streetcomplete:master Apr 22, 2024
@urbalazs urbalazs deleted the payment-others branch April 22, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants