Differenciate between roads and pedestrian streets #862
Conversation
|
I also added another answer for if the street is tagged with |
|
That's a very good idea, nice! |
But what about this note: https://www.openstreetmap.org/note/1297034 which references https://www.openstreetmap.org/way/365260406 with |
|
and the last note is about the surface quest, not the name quest. |
|
BTW, generally, just saw what I once wrote for that quest in the wiki as a question: "What is the name of this place?" |
|
Uh, wait, that's another quest… But if you are going into areas that is not really a road quest… |
|
Maybe it was done using version not including 10f8beb ? |
|
Oops... It was the surface quest... I will revert the last commit. |
|
I removed the additional area question from the road name question but added it to the road surface question as it might make sense to include it there... |
| @@ -164,7 +164,10 @@ else if(noProperRoad == AddRoadNameForm.IS_LINK) | |||
| @Override public String getCommitMessage() { return "Determine road names and types"; } | |||
| @Override public int getIcon() { return R.drawable.ic_quest_street_name; } | |||
| @Override public int getTitle() { return R.string.quest_streetName_title; } | |||
| @Override public int getTitle(@NonNull Map<String,String> tags) { return getTitle(); } | |||
| @Override public int getTitle(@NonNull Map<String,String> tags) { | |||
| if (tags.get("highway").equals("pedestrian")) return R.string.quest_streetName_pedestrian_title; | |||
There was a problem hiding this comment.
Is it not enough to assume that thanks to https://github.com/ENT8R/StreetComplete/blob/c69465407a868021fb8f843ba9795a2fc47be3b4/app/src/main/java/de/westnordost/streetcomplete/quests/road_name/AddRoadName.java#L42 highway tag will be always present?
There was a problem hiding this comment.
I thought that too...
There was a problem hiding this comment.
Possibly, there won't be a problem with this now, but there may be in the future:
By contract (=by interface), it is only guaranteed that the tags parameter will never be null, it does not say anything about which tags must be present.
Note that the default implementation of getTitle in SimpleOverpassQuestType is:
@Override public final int getTitle()
{
return getTitle(Collections.emptyMap());
}
So, asserting that every call to getTitle(@NonNull Map<String,String> tags) must carry the correct tags from the associated element with it, comes down to asserting that getTitle() will never be called on OsmQuestTypes. Ulteriorly "removing" methods from the interface this way is prone to error, as this is not obvious to anyone.
|
I'll just merge it and correct it afterwards. |
While reviewing StreetComplete-related notes I saw many people irritated by the fact that StreetComplete can't differenciate between roads for cars and pedestrian streets.
This PR fixes this issue.
Some examples are:
https://www.openstreetmap.org/note/1296735
https://www.openstreetmap.org/note/1179245
https://www.openstreetmap.org/note/1174269
https://www.openstreetmap.org/note/1174268
https://www.openstreetmap.org/note/1174267
https://www.openstreetmap.org/note/1123039
https://www.openstreetmap.org/note/1290931
https://www.openstreetmap.org/note/1289562