Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain objects with no name #22

Closed
Haikuch opened this issue Mar 21, 2017 · 5 comments
Closed

explain objects with no name #22

Haikuch opened this issue Mar 21, 2017 · 5 comments

Comments

@Haikuch
Copy link

Haikuch commented Mar 21, 2017

sometimes there are objects without a name, like this one:

https://www.openstreetmap.org/node/573381069

Then the app does just ask "What are the opening hours of this object" and you might not know exactly what object is meant (I only guessed it). For this situations it would be better to see something like "what are the opening hours of this object (shop=funeral_directors)"

@westnordost
Copy link
Member

westnordost commented Mar 21, 2017 via email

@Haikuch
Copy link
Author

Haikuch commented Mar 21, 2017

You are right, I will disable opening hours quests for objects that are not named.

mh, that was not my intention. I would prefer to explain them with the tagging (like shop=*). That might not be the most beautiful solution, but I personally like it more to have raw informations. I see that many developers don't like to confront their users with tags, but in a mapping tool it should be ok.

Such a dictionary does not exist yet.

yes I know, thats a large gap for the use of OSM DB. I once started a project to collect this dictionary, but had to drop it because of time. At least there is this list thats also used by nominatim:

https://wiki.openstreetmap.org/wiki/Nominatim/Special_Phrases

@westnordost
Copy link
Member

Regarding the ticket at hand: I will also add a quest "whats the name of this place", so that's covered.

@daniel-j-h
Copy link

Just stumbled upon the same behavior. In Berlin I can occasionally see Quests such as "What are the opening hours of null?" e.g. for this building http://www.openstreetmap.org/way/28251565

sc

The fix in ad5472e requires a name tag to be present. The question is if there are unnamed buildings for which it would still make sense to add opening hours. Would it make sense to not require a name tag but instead show "What are the opening hours of this building" for these cases?

@rugk
Copy link
Contributor

rugk commented Oct 21, 2017

When will this quest be included in the StreetComplete release? It's already in master, but according to @DavidDean, not currently active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants