Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add place name quest (fixes #309, unblocks #1354) #1376

Merged
merged 5 commits into from
Apr 24, 2019
Merged

Conversation

westnordost
Copy link
Member

Still todo:

  • see if it is possible to somehow replace those escaped unicode characters in the localizations with normal characters (as the JSONs are already UTF-8)
  • update readme etc. to link the osmnames repository
  • update readme etc. to mention where the translation data is from (and how to contribute / report bugs)

@rugk
Copy link
Contributor

rugk commented Apr 14, 2019

Hint: GitHub does not link/care about issue/PR numbers linked in the title of PRs (or issues, for what it's worth).

Edit: Actually, it (also) fixes #22.

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Apr 14, 2019

You are right with linking. Closing should work

fixes #309, unblocks #1354

@rugk
Copy link
Contributor

rugk commented Apr 14, 2019

Sorry for doing this off-topic discussion, but yeah, not even closing works, actually. It only works if/because the same is mentioned in the commit. However, in this case here (where the commit message is different) even that does not work.

@westnordost westnordost merged commit a137ccc into master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants