Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom to view minimum 5 locations of selected category on mobile #81

Open
adambard1 opened this issue Feb 16, 2024 · 6 comments
Open

Zoom to view minimum 5 locations of selected category on mobile #81

adambard1 opened this issue Feb 16, 2024 · 6 comments
Assignees
Labels
Deploy but don't close Improved over prod, but more to do high-prio QA done Under review fixed locally, awaiting code review and QA

Comments

@adambard1
Copy link

adambard1 commented Feb 16, 2024

Particularly relevant for mobile. If users have their location on, or if they're using the default central park location, when they select a category the map should zoom to return at least 5 visible results (or, all results if there less than 5) close to their location

@adambard1
Copy link
Author

If we could get this done for launch it would be great. There are a lot of results that return an empty map window if you live in south brooklyn or queens, which is confusing as a user.

@adambard1
Copy link
Author

Seems to be an issue when clicking various functions like filters or centering that we zoom to our default rather than maintain the user selection or zoom out to see min 5 location results.

@adambard1 adambard1 changed the title refactor: Zoom to view minimum 5 locations of selected category refactor: Zoom to view minimum 5 locations of selected category on mobile Feb 29, 2024
@adambard1
Copy link
Author

Seems that on desktop default is meant to be zoom to 25 locations. This is OK if there are more than 25 results.

@adambard1
Copy link
Author

Expected behavior would be that if the user has manually changed zoom, then we don't zoom out unless it is to show selections that would otherwise not be on the map (e.g. for 5 locations on mobile and 25 on desktop), or a search result

@adambard1 adambard1 removed the bug Something isn't working label Mar 8, 2024
@adambard1 adambard1 changed the title refactor: Zoom to view minimum 5 locations of selected category on mobile Zoom to view minimum 5 locations of selected category on mobile Mar 8, 2024
@jbeard4 jbeard4 transferred this issue from another repository May 5, 2024
@shakilhossain1 shakilhossain1 added the Under review fixed locally, awaiting code review and QA label May 15, 2024
@adambard1 adambard1 added QA done Deploy but don't close Improved over prod, but more to do labels May 16, 2024
@adambard1
Copy link
Author

I'm not really sure what the logic applied is but it's better than before. Let's deploy this but leave it open till understanding what we are doing.

@adambard1
Copy link
Author

Chosen logic is for desktop it zooms to a minimum of 5 locations, but if there are more than 10 results it will only show 10 locations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deploy but don't close Improved over prod, but more to do high-prio QA done Under review fixed locally, awaiting code review and QA
Projects
Status: In Progress
Development

No branches or pull requests

3 participants