Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(segment): add cafe seating #1480

Merged
merged 1 commit into from
Aug 8, 2019
Merged

feat(segment): add cafe seating #1480

merged 1 commit into from
Aug 8, 2019

Conversation

louh
Copy link
Member

@louh louh commented Aug 8, 2019

We've never been happy with the final state of this artwork, but now it's officially in Streetmix behind a feature flag.

Screenshot 2019-08-08 09 40 53

@louh louh requested a review from whitmanschorn August 8, 2019 13:42
@codecov-io
Copy link

codecov-io commented Aug 8, 2019

Codecov Report

Merging #1480 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1480   +/-   ##
======================================
  Coverage    34.6%   34.6%           
======================================
  Files         248     248           
  Lines        9182    9182           
  Branches     1986    1986           
======================================
  Hits         3177    3177           
  Misses       5401    5401           
  Partials      604     604

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437f550...b3806cd. Read the comment docs.

"occupants|empty": "Empty",
"occupants|full": "Full",
"elevation|sidewalk": "Sidewalk level",
"elevation|road": "Street levelx"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the x at the end might be a typo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it is, thanks for catching it!

Copy link
Collaborator

@whitmanschorn whitmanschorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out locally and it looks good! Let's fix the Street Levelx typo and then this can merge 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants