-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(segment): add cafe seating #1480
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1480 +/- ##
======================================
Coverage 34.6% 34.6%
======================================
Files 248 248
Lines 9182 9182
Branches 1986 1986
======================================
Hits 3177 3177
Misses 5401 5401
Partials 604 604 Continue to review full report at Codecov.
|
assets/locales/en/segment-info.json
Outdated
"occupants|empty": "Empty", | ||
"occupants|full": "Full", | ||
"elevation|sidewalk": "Sidewalk level", | ||
"elevation|road": "Street levelx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the x
at the end might be a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed it is, thanks for catching it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this out locally and it looks good! Let's fix the Street Levelx
typo and then this can merge 🚢
We've never been happy with the final state of this artwork, but now it's officially in Streetmix behind a feature flag.