refactor(react-intl): update to v3 #1482
Conversation
| import { PELIAS_HOST_NAME, PELIAS_API_KEY } from '../../app/config' | ||
| import { setMapState } from '../../store/actions/map' | ||
|
|
||
| class GeoSearch extends React.Component { | ||
| static propTypes = { | ||
| intl: intlShape.isRequired, | ||
| intl: PropTypes.object.isRequired, |
There was a problem hiding this comment.
Not a huge deal, but I it looks like in v3 react-intl exports an [IntlShape](https://github.com/formatjs/react-intl/blob/master/docs/Upgrade-Guide.md#typescript-support), could we use that here with PropTypes.shape?
There was a problem hiding this comment.
Didn't work, and I suppose that's to be expected — I don't think TypeScript and PropTypes are compatible, as they're totally different systems for typechecking.
| @@ -19,30 +18,33 @@ describe('StreetMetaWidthContainer', () => { | |||
| expect(wrapper.asFragment()).toMatchSnapshot() | |||
| }) | |||
|
|
|||
| it('updates street label on selection change', () => { | |||
| it.skip('updates street label on selection change', () => { | |||
There was a problem hiding this comment.
Just wanna double check - are we skipping this test and the one below it on purpose?
There was a problem hiding this comment.
These are skipped on purpose for now, since we need to rewrite these tests for them to pass. (As discussed, this component's interaction is a great candidate for Cypress.)
No description provided.