Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual cleanup() from react-testing-library test suites #1616

Merged
merged 2 commits into from Oct 18, 2019
Merged

Remove manual cleanup() from react-testing-library test suites #1616

merged 2 commits into from Oct 18, 2019

Conversation

andrelmlins
Copy link
Contributor

Regarding #1615

Copy link
Member

@louh louh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @andrelmlins!

We still need to remove the import of cleanup in each test suite, since they're not necessary anymore. You can run npm test from your command line which should let you know which modules still import it but can be removed. Our CI test infrastructure is alerting us to this, as well: https://travis-ci.org/streetmix/streetmix/builds/599424413?utm_source=github_status&utm_medium=notification

Once this is done and tests are passing, we should be good to merge! Thanks again!

@andrelmlins
Copy link
Contributor Author

Ok @louh

Removed imports from cleanup

@andrelmlins andrelmlins requested a review from louh October 18, 2019 12:01
@louh
Copy link
Member

louh commented Oct 18, 2019

Excellent. This is good to go. Thank you so much for your contribution! 🚀

@louh louh merged commit bdc1e50 into streetmix:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants