Add CUDA and QSV to allowed decoder list #238
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original Chiaki (and most of the Qt6 ports I've used), the entirety of the decoder list was added to this dropdown box. This allowed me to use CUDA and QSV on systems where I had access to these.
I've added CUDA and QSV to the allowed decoders list for all Operating Systems, as far as I'm aware these should both be available on Linux and Windows at the very least.
I've tested both CUDA and QSV by manually editing my saved registry values on Windows and both seem to work fine, I don't have easy access to a Linux device to test on there.
I'm happy to move these into the Windows and Linux blocks specifically to prevent macOS users from selecting it.
There are other decoders that could be enabled, such as DVXA2 (Windows-only) and OpenCL, however I'm unaware of either of these have any practical purpose now that Vulkan, VA-API and D3D11VA exist and are decent on most systems.