Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action does not respect files filter in config #1395

Closed
milesfrain opened this issue Oct 7, 2023 · 1 comment · Fixed by #1605
Closed

Action does not respect files filter in config #1395

milesfrain opened this issue Oct 7, 2023 · 1 comment · Fixed by #1605

Comments

@milesfrain
Copy link

milesfrain commented Oct 7, 2023

I'd expect the github action to respect the same file filter contained in the cspell config, but this filter is ignored.
There is a separate file filter that we can configure for just the action, but now we're duplicating rules, and inviting different behavior when running cspell locally, versus via the github action.

Here's an example of the issue:
milesfrain/cspell-demo#2

A workaround could be to omit the files filter, and instead only specify ignorePaths in the local config.

@milesfrain milesfrain changed the title Action does not respect file filter in config Action does not respect files filter in config Oct 7, 2023
@nickzelei
Copy link

nickzelei commented Jan 30, 2024

I'm also hitting this too. Currently makes the action unusable for me because I'm relying on the files pretty heavily to ignore the rest of the folder.

A cursory look at the code, the action script only uses the files property from the action input. So it ignores the files defined in the config entirely. It is uses the config for other reasons it appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants