-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action does not respect files
filter in config
#1395
Comments
file
filter in configfiles
filter in config
I'm also hitting this too. Currently makes the action unusable for me because I'm relying on the files pretty heavily to ignore the rest of the folder. A cursory look at the code, the action script only uses the files property from the action input. So it ignores the files defined in the config entirely. It is uses the config for other reasons it appears. |
Jason3S
added a commit
that referenced
this issue
Mar 1, 2024
Jason3S
added a commit
that referenced
this issue
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'd expect the github action to respect the same file filter contained in the
cspell
config, but this filter is ignored.There is a separate file filter that we can configure for just the action, but now we're duplicating rules, and inviting different behavior when running
cspell
locally, versus via the github action.Here's an example of the issue:
milesfrain/cspell-demo#2
A workaround could be to omit the
files
filter, and instead only specifyignorePaths
in the local config.The text was updated successfully, but these errors were encountered: