Improve cspell pre-commit hook output #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a pre-commit passes, you don't want to see output other than "Passed"
cspell-cli progress clutters the pre-commit output when errors are found
|
Thank you for the PR. Did you try? To get more options: |
|
I intend to add documentation on the available command line options to the README, but in the meantime, I've pasted them into #54. |
Ah thanks yes, and I see this has been addressed in #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, thanks a lot for extracting this repo from cspell! Now it's much easier to run cspell through pre-commit. (Previously did that through this mirror, which I'll archive.)
Here's a suggested change to the hook config, so that it's easier to read the pre-commit output (particularly when running over all files). Pre-commit users can of course configure this themselves through their own
.pre-commit-config.yaml, but I think this should become the default behaviour.Intended behaviour is shown below. Can be reproduced with:
pre-commit try-repo . --all-filesb07cfd1: no verbose
Old (v5.6.7)
New
7615279: no progress
Old (v5.6.7 / b07cfd1)
New