Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node:worker_threads breaks on node 14 #4185

Merged
merged 2 commits into from
Feb 16, 2023
Merged

fix: node:worker_threads breaks on node 14 #4185

merged 2 commits into from
Feb 16, 2023

Conversation

Jason3S
Copy link
Collaborator

@Jason3S Jason3S commented Feb 16, 2023

fixes #4184

@github-actions github-actions bot added the fix label Feb 16, 2023
@Jason3S Jason3S marked this pull request as ready for review February 16, 2023 06:19
@nschonni
Copy link
Collaborator

Not sure if the updated version of eslint-plugin-node called eslint-plugin-n would catch this or not.

@Jason3S Jason3S merged commit 8654ac7 into main Feb 16, 2023
@Jason3S Jason3S deleted the dev-fix-4184 branch February 16, 2023 07:58
@Jason3S
Copy link
Collaborator Author

Jason3S commented Feb 16, 2023

Not sure if the updated version of eslint-plugin-node called eslint-plugin-n would catch this or not.

It was a combination of things that caused this to happen. The unit tests would normally have caught this because they run on all node versions, but something in the switch from jest to vitest may cause it run differently.

Also a simple smoke test would have gotten this, but node 14 was dropped in favor of 19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Possible breaking change for node v14.16.0
2 participants