Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support multiple repMap combinations #4270

Merged
merged 3 commits into from
Mar 3, 2023
Merged

feat: Support multiple repMap combinations #4270

merged 3 commits into from
Mar 3, 2023

Conversation

Jason3S
Copy link
Collaborator

@Jason3S Jason3S commented Mar 3, 2023

It is possible to define a repMap in the dictionary definition. This allows for sub-string substitutions. It use to be an ALL or nothing option.

Old behavior:

  • Goerresstraße -> Görreßtraße which won't match the correct word of Görresstraße.

New behavior:

  • Goerresstraße -> Goerresstraße, Goerreßtraße, Görresstraße, Görreßtraße

Note, this is only applied to words being checked, not words in the dictionary.

Dictionary contains:

  • Görresstraße

This also addresses these issues:

It is possible to define a `repMap` in the dictionary definition. This allows for sub-string substitutions. It use to be an ALL or nothing option.

Old behavior:
- `Goerresstraße` -> `Görreßtraße` which won't match the correct word of `Görresstraße`.

New behavior:
- `Goerresstraße` -> 'Goerresstraße', 'Goerreßtraße', 'Görresstraße', 'Görreßtraße'
@Jason3S Jason3S marked this pull request as ready for review March 3, 2023 18:48
@Jason3S Jason3S merged commit bbc3ed4 into main Mar 3, 2023
@Jason3S Jason3S deleted the dev-rep branch March 3, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant