Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust docker command in README to match common samples #4387

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

kamontat
Copy link
Contributor

No description provided.

@kamontat kamontat changed the title fix: invalid docker command fix: invalid docker command in README Apr 12, 2023
@Jason3S
Copy link
Collaborator

Jason3S commented Apr 12, 2023

@kamontat,

What is invalid about it?

@Jason3S Jason3S merged commit 144e2f2 into streetsidesoftware:main Apr 12, 2023
10 checks passed
@Jason3S Jason3S changed the title fix: invalid docker command in README fix: adjust docker command in README to match common samples Apr 13, 2023
@Jason3S
Copy link
Collaborator

Jason3S commented Apr 13, 2023

@kamontat,

There was nothing wrong with the example in the README. It worked just fine. I decided to take your suggestion because it matches a lot of the example given on the Docker website.

@kamontat
Copy link
Contributor Author

@Jason3S Sorry, I just saw your message. It invalid because -t don't expected any value but in README, it pass $PWD:/workdir as value that should be for -v (--volume option). If you copy the command and run on terminal it will throw docker: invalid reference format: repository name must be lowercase..

$ docker run -v -i -t $PWD:/workdir ghcr.io/streetsidesoftware/cspell:latest lint

docker: invalid reference format: repository name must be lowercase.
See 'docker run --help'.

CleanShot 2023-04-17 at 15 15 32@2x

However, with my fixed:

CleanShot 2023-04-17 at 15 16 30@2x

@kamontat kamontat deleted the patch-1 branch April 17, 2023 08:17
@Jason3S
Copy link
Collaborator

Jason3S commented Apr 17, 2023

@kamontat,

Thank you. Strangely it had worked, but clearly should not have.

When I saw your PR, I tried it out on a near-by machine (it happened to be Windows) and it worked there. But, I get the same issue you are seeing when I run it in MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants