Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Explicit rimraf devDependency #480

Merged
merged 1 commit into from
Oct 31, 2020

Conversation

nschonni
Copy link
Collaborator

Also update the on explict older version in util-bundle

@nschonni
Copy link
Collaborator Author

Maybe this isn't supposed to be required with lerna, but I got an error running npm i at the root

> cspell@5.0.1-alpha.7 clean Z:\cspell\packages\cspell
> rimraf dist


lerna ERR! npm run clean-build stderr:
internal/modules/cjs/loader.js:883
  throw err;
  ^

Error: Cannot find module 'Z:\cspell\packages\cspell\node_modules\rimraf\bin.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
    at Function.Module._load (internal/modules/cjs/loader.js:725:27)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! cspell@5.0.1-alpha.7 clean: `rimraf dist`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the cspell@5.0.1-alpha.7 clean script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\nick_\AppData\Roaming\npm-cache\_logs\2020-10-31T16_37_16_059Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! cspell@5.0.1-alpha.7 clean-build: `npm run clean && npm run build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the cspell@5.0.1-alpha.7 clean-build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\nick_\AppData\Roaming\npm-cache\_logs\2020-10-31T16_37_16_125Z-debug.log

lerna ERR! npm run clean-build exited 1 in 'cspell'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! cspell-monorepo@1.0.0 clean-build: `lerna run clean-build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the cspell-monorepo@1.0.0 clean-build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\nick_\AppData\Roaming\npm-cache\_logs\2020-10-31T16_37_16_297Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! cspell-monorepo@1.0.0 prepare: `npm run symlink && npm run clean-build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the cspell-monorepo@1.0.0 prepare script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\nick_\AppData\Roaming\npm-cache\_logs\2020-10-31T16_37_16_471Z-debug.log

@coveralls
Copy link

coveralls commented Oct 31, 2020

Coverage Status

Coverage increased (+2.5%) to 100.0% when pulling 874414a on nschonni:rimraf into 30eedf7 on streetsidesoftware:master.

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #480 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #480   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          85       85           
  Lines        3609     3609           
  Branches      604      604           
=======================================
  Hits         3552     3552           
  Misses         54       54           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30eedf7...874414a. Read the comment docs.

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 31, 2020

Lerna is NOT a perfect tool. It makes some things easier and others much harder.
As a whole, it makes publishing much easier.
A local dev copy of rimraf should not be needed.
At the repository root, npm i should be enough to build the entire project.
To build a single package, something like this from the root: npm run build -- --scope cspell-lib

Upgrading local dev packages is a bit of a pain with Lerna. I guess I missed removing on from cspell-util-bundle.

Also update the on explict older version in util-bundle
@Jason3S Jason3S merged commit 46e51f8 into streetsidesoftware:master Oct 31, 2020
@nschonni nschonni deleted the rimraf branch October 31, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants