fix: Do not show context menu if editorReadonly (#2590)

streetsidesoftware · Mar 14, 2023 · 86aeafd · 86aeafd
1 parent 23a0df9
commit 86aeafd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -51,13 +51,13 @@
       "editor/context": [
         {
           "command": "cSpell.suggestSpellingCorrections",
-          "when": "editorTextFocus && config.cSpell.showSuggestionsLinkInEditorContextMenu && cSpell.editorMenuContext.showSuggestions",
+          "when": "!editorReadonly && editorTextFocus && config.cSpell.showSuggestionsLinkInEditorContextMenu && cSpell.editorMenuContext.showSuggestions",
           "group": "A_cspell@000"
         },
         {
           "submenu": "cSpell.spelling",
           "group": "A_cspell@001",
-          "when": "editorTextFocus && config.cSpell.showCommandsInEditorContextMenu"
+          "when": "!editorReadonly && editorTextFocus && config.cSpell.showCommandsInEditorContextMenu"
         }
       ],
       "cSpell.spelling": [

diff --git a/packages/client/src/context.ts b/packages/client/src/context.ts
@@ -77,6 +77,10 @@ const defaultEditorMenuContext: EditorMenuContext = Object.freeze({
     addIgnoreWord: false,
 });
 
+const allowContextMenuForScheme: Record<string, boolean | undefined> = {
+    output: false,
+};
+
 /**
  * Set context values
  * @param name - name of context to set
@@ -119,6 +123,10 @@ export async function updateDocumentRelatedContext(client: CSpellClient, doc: Te
         return;
     }
 
+    if (allowContextMenuForScheme[doc.uri.scheme] === false) {
+        return;
+    }
+
     const _doc = doc;
 
     const cached = cachedUpdateDocumentRelatedContext.get(_doc);