Skip to content

Commit

Permalink
fix: change fixSpellingWithRenameProvider defaults (#2271)
Browse files Browse the repository at this point in the history
fix: #2268

- Turn on rename provider in PHP. It no-longer crashes.
- Turn off rename provider for CSS and SCSS. It does the wrong thing.
  • Loading branch information
Jason3S committed Oct 3, 2022
1 parent 6de2de5 commit bea43a7
Show file tree
Hide file tree
Showing 4 changed files with 96 additions and 3 deletions.
9 changes: 6 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -403,13 +403,16 @@
}
],
"configurationDefaults": {
"[php]": {
"cSpell.fixSpellingWithRenameProvider": false
},
"[markdown]": {
"cSpell.fixSpellingWithRenameProvider": true,
"cSpell.advanced.feature.useReferenceProviderWithRename": true,
"cSpell.advanced.feature.useReferenceProviderRemove": "/^#+\\s/"
},
"[scss]": {
"cSpell.fixSpellingWithRenameProvider": false
},
"[css]": {
"cSpell.fixSpellingWithRenameProvider": false
}
},
"configuration": [
Expand Down
30 changes: 30 additions & 0 deletions samples/scss/example.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
#page {
display: grid;
width: 100%;
height: 200px;
grid-template:
[header-left] 'head head' 30px [header-right]
[main-left] 'nav main' 1fr [main-right]
[footer-left] 'nav foot' 30px [footer-right]
/ 120px 1fr;
}

header {
background-color: lime;
grid-area: head;
}

nav {
background-color: lightblue;
grid-area: nav;
}

main {
background-color: yellow;
grid-area: main;
}

footer {
background-color: red;
grid-area: foot;
}
30 changes: 30 additions & 0 deletions samples/scss/example.sass
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
#page {
display: grid;
width: 100%;
height: 200px;
grid-template:
[header-left] 'head head' 30px [header-right]
[main-left] 'nav main' 1fr [main-right]
[footer-left] 'nav foot' 30px [footer-right]
/ 120px 1fr;
}

header {
background-color: lime;
grid-area: head;
}

nav {
background-color: lightblue;
grid-area: nav;
}

main {
background-color: yellow;
grid-area: main;
}

footer {
background-color: red;
grid-area: foot;
}
30 changes: 30 additions & 0 deletions samples/scss/example.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
#page {
display: grid;
width: 100%;
height: 200px;
grid-template:
[header-left] 'head head' 30px [header-right]
[main-left] 'nav main' 1fr [main-right]
[footer-left] 'nav foot' 30px [footer-right]
/ 120px 1fr;
}

header {
background-color: lime;
grid-area: head;
}

nav {
background-color: lightblue;
grid-area: nav;
}

main {
background-color: yellow;
grid-area: main;
}

footer {
background-color: red;
grid-area: foot;
}

0 comments on commit bea43a7

Please sign in to comment.