-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working in Git COMMIT_EDITMSG #346
Comments
It is possible to enable the spell checker: "cSpell.ignorePaths": [
"**/node_modules/**",
"**/package-lock.json",
"**/vscode-extension/**",
"**/.git/**", // <-- Remove this line
".vscode"
], Note: if you have a |
It looks like the comment (#346 (comment)) by @Jason3S should no longer be necessary as of f940193 |
However, the issue still persists for me |
@vegerot I had the same issue. I solved it by setting the option |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
TL;DR
Extensions isn't working in the
COMMIT_EDITMSG
document that pops up when you have VSCode set as your Git editor and rungit commit
.I've got
git-commit
listed incSpell.enabledLanguageIds
array, and have snippets working in it so I don't think I got the language ID wrong.Any ideas?
Details
It seems pretty well established that VSCode users want am editing experience in the built-in Git commit input area better on par with the rest of the app, including spell checking support (#109).
In the meantime, I'm trying out the old-school
git commit
with VSCode setup as my$EDITOR
so it opens a full document, like so:One of the features I was hopping to achieve most is spell checking (extension's been great BTW, thanks). However, as you can see from the screen shot, the extension does not appear to be picking it up.
My
settings.json
includes:The
git-commit
language ID has worked fine for snippets, which makes me feel like it's correct.These commit message files live at
<PROJECT>/.git/COMMIT_EDITMSG
, which is ignored in the project as part of the.git
directory, so maybe that has something to do with it?I also see from #109 that there are path-based exclude filters on the spell check server, but neither any of the patterns listed there or where they seems to have moved in the current source
vscode-spell-checker/packages/_server/src/documentSettings.ts
Line 42 in 0c2633d
look like they would apply to the commit message files.
Solutions or suggestions much appreciated, thanks. If a change is needed I can see if I can find some time to take a swing, but time honestly is my most scarce resource at the moment.
The text was updated successfully, but these errors were encountered: