Sync stops working on macOS after resume from sleep

[streetwriters]

I haven't tested on other platforms, but on macOS, if the computer goes to sleep and is resumed, with Notesnook still running, the status bar at the bottom shows sync failed.

In this state, I created a new note on mobile (iOS) and made sure sync was done on the phone. The note did not sync to desktop, I had to initial a force sync by cling on the "sync failed" message in the status bar.

Running on an M1 MacBook Pro, macOS Ventura 13.3.1 (22E261)

Device information:
App version: 2.4.7-71ecc05-desktop
OS: OS X 10.15.7
Browser: Electron 21.1.1
Pro: true

[ajgraves]

Please let me know if any additional details are needed for this report.

[thecodrr]

I was able to reproduce this on Linux as well. Fixing it ASAP. Thanks for reporting!

[thecodrr]

Detailing my findings here.

When a device goes to sleep, its Internet/WiFi gets disconnected which also stops the Notesnook app from syncing and puts it in offline mode. However, when the device wakes up it takes some time for it to connect to the Internet. During this time, the Notesnook app also tries and fails to connect its sync throwing the "Could not connect to sync server" error.

I was not able to reproduce this on the web app so I am assuming this has something to do with how/when Electron sends the reconnection/device wake event.

A possible fix for it would be to send more reliable connectivity events from the native side instead of relying on the browser.

[ajgraves]

This still seems to be an issue, at least on macOS. Still shows "Sync failed" until I click on that to force a sync.