Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notes migrated from previous version have newlines replaced by the string "[[%NN_NEWLINE_IN_PRE%]]" everywhere #735

Closed
avatar382 opened this issue Jul 25, 2022 · 4 comments
Assignees
Labels
Status: Confirmed Bug is confirmed but work on a fix hasn't yet started. Type: Bug Something isn't working

Comments

@avatar382
Copy link

What happened?

After updating to the latest version of Notesnook, with the updated code block editor, I'm seeing many notes with newlines replaced with the string "[[%NN_NEWLINE_IN_PRE%]]" all over the place.

Here's an example:
Screenshot_2022-07-25_09-33-34

Steps to reproduce the problem

The step taken was simply upgrading Notesnook to the most recent version.

Version

v2.1.2-fede059-desktop

Platform/OS

Linux

Relevant log output

No response

@avatar382 avatar382 added Status: Pending Type: Bug Something isn't working labels Jul 25, 2022
@thecodrr thecodrr added Status: Confirmed Bug is confirmed but work on a fix hasn't yet started. and removed Status: Pending labels Jul 26, 2022
@thecodrr
Copy link
Contributor

This is a critical bug in the migration system (which was fixed but an edge case slipped through). I have redone the logic around codeblock migration which should fix this.

However, your notes will need to be remigrated once v2.1.3 (on web/desktop) is out. This can be done by restoring a recent backup.

If that is not possible, I can reset your account to the state it was before the migration to the new version.

@avatar382
Copy link
Author

Ok, sounds good.

Once 2.1.3 comes out, can I simply install that version and have the notes I haven't cleaned up yet be automatically fixed?

I've fixed quite a few notes already and would rather not revert back now that this work has been done.

@thecodrr
Copy link
Contributor

Once 2.1.3 comes out, can I simply install that version and have the notes I haven't cleaned up yet be automatically fixed?

Unfortunately no. The fastest way is to import a recent backup which will fix all the notes. The second fastest way is to import the backup in a temporary account and copy paste the affected notes from that account to your own one by one.

@thecodrr
Copy link
Contributor

thecodrr commented Aug 6, 2022

If this is resolved for you @avatar382 we can close it.

@thecodrr thecodrr closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Confirmed Bug is confirmed but work on a fix hasn't yet started. Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants