Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n support for multiple languages #951

Closed
santb08 opened this issue Sep 9, 2022 · 9 comments
Closed

i18n support for multiple languages #951

santb08 opened this issue Sep 9, 2022 · 9 comments
Labels

Comments

@santb08
Copy link

santb08 commented Sep 9, 2022

What problem are you facing?

Noticed that notebook supports English only, and this can limit the number of users from many different regions

What's the solution you'd like to see in Notesnook?

Implementing trend libraries such as i18n
I can create a PoC for that and change some texts to don't make a big change
I can help to translate the app to Spanish as I'm native from Latinoamerica

What alternatives have you considered?

We can create our custom solution using JSON dictionaries or using react-intl, but I'd rather prefer i18n

Additional context

I think that even if you're planning to have 1 language only there'd be at least a standard for messages/texts shown in the app

@JonZhang3
Copy link

In progress?

@santb08
Copy link
Author

santb08 commented Sep 15, 2022

In progress?

waiting for any approval tbh

@thecodrr
Copy link
Contributor

Okay the first step towards this would be standarizing all the strings in all the client apps everywhere. We'd also want this to be simple to maintain and extend. I haven't worked with i18n before (so can you give some resources I can look into)? JSON is not a totally bad idea but we'd probably want it to integrate with something like Crowdin (or an open source alternative to it).

Framework integration is not a bad idea either but I'll have to research on that. Another thing to consider is the UI side of things. For example, in German the texts can be quite long so we'd need some way to test that out.

@santb08
Copy link
Author

santb08 commented Sep 18, 2022

Well, I'd like to go with i18next library that goes beyond i18n framework. It supports Crowdin and many other language platforms, and you can see it in a nutshell with the crash course on its docs site: https://www.i18next.com/

Also, I think that starting with languages support can help any other devs who might want to start in the open source world, they could help with translation things and fitting texts as you mentioned

In the first place, we can only start with languages tan can be kinda similar, such as English, Spanish, Italian, and on demand...

But at the very beginning, English, by moving the languages into Crowdin as you mentioned

@dyw770
Copy link

dyw770 commented Oct 29, 2022

hi, any progress now?

@inson1
Copy link

inson1 commented Oct 28, 2023

I'm against Crowdin and I would prefer Hosted Weblate. It's open source.

@fallsdevil
Copy link

I'm against Crowdin and I would prefer Hosted Weblate. It's open source.

I agree, I'm logged in to both but I prefer weblate too to help translate!

@jermanuts
Copy link

Any updates? I agree with using Weblate.

@shuvashish76
Copy link

We've #865 discussion for this purpose.

@santb08 santb08 closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants