assert: indentMessageLines - build message with bytes instead of string

stretchr · Mar 7, 2024 · 594ac7d · 594ac7d
1 parent 6b0dfad
commit 594ac7d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/assert/assertions.go b/assert/assertions.go
@@ -317,7 +317,7 @@ func indentMessageLines(message string, longestLabelLen int) string {
 			outBuf.WriteString("\n\t" + strings.Repeat(" ", longestLabelLen+1) + "\t")
 		}
 
-		outBuf.WriteString(msgScanner.Text())
+		outBuf.Write(msgScanner.Bytes())
 		first = false
 	}
 

diff --git a/assert/assertions_priv_test.go b/assert/assertions_priv_test.go
@@ -6,14 +6,9 @@ import (
 	"testing"
 )
 
-const (
-	// set maxScanTokenSize to 1 more than the default set by bufio. This will
-	// cover the case where a single line is longer than the default
-	// maxScanTokenSize
-	maxScanTokenSize = bufio.MaxScanTokenSize + 1
-)
-
 func Test_indentMessageLines(t *testing.T) {
+	const maxScanTokenSize = bufio.MaxScanTokenSize + 1
+
 	tt := []struct {
 		name            string
 		msg             string