mock: improve MatchedBy failed comparison Diff message #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@boyan-soubachov Please could you take a look? |
boyan-soubachov
approved these changes
Aug 24, 2021
dolmen
added
enhancement
pkg-mock
dolmen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve the Diff message for
mock.MatchedByfunctions taking a reference type.Changes
The
argumentMatcher.Stringmethod internally now uses thereflect.Type.Stringmethod instead of thereflect.Type.Namemethod.Motivation
Prior to this change a
mock.MatchedByfunction taking a reference type, such as a slice (func([]int) bool), would have the Diff presented as... func() bool; now the Diff will accurately be presented as... func([]int) bool.Related issues
N/A