Ensure that subtest name is set in SetupSubTest/TearDownSubTest #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolmen
added
Changes Requested
pkg-suite
tomhutch
reviewed
Jul 26, 2023
suite/suite_test.go
Outdated
Comment on lines
263
to
265
| subTestT := suite.T() | ||
| suite.NotEqual(subTestT, suite.SuiteT) | ||
|
|
There was a problem hiding this comment.
Hey, something like this would allow you to add your assertions alongside the others and call assert.Contains with the specific values we expect to see:
Suggested change
| subTestT := suite.T() | |
| suite.NotEqual(subTestT, suite.SuiteT) | |
| suite.TearDownSubTestNames = append(suite.SetupSubTestNames, suite.T().Name()) |
|
Thanks for the review @tomhutch -- is this similar to what you were thinking? |
|
Hey @tomhutch -- this is ready for re-review |
|
This will be fixed by #1471. @thekidder I'm sorry your own MR didn't get the attention it needed. Could you help the community effort by adding your review to #1471? |
|
#1471 looks like a great fix, thanks for pointing me toward that. Will close this request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that subtest name is set in SetupSubTest/TearDownSubTest
Changes
Motivation
One common usecase of SetupSubTest is to set up mocks and expectations for a table test. In this usecase, the current behavior does not set the test name until after SetupSubTest is run. This makes test failure reporting substantially less informative.