fix: update Empty()'s error message #1398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message returned by Empty() is a bit confusing because it states the following: Should be empty, but was.
dolmen
requested changes
Jul 6, 2023
| @@ -705,7 +705,7 @@ func Empty(t TestingT, object interface{}, msgAndArgs ...interface{}) bool { | |||
| if h, ok := t.(tHelper); ok { | |||
| h.Helper() | |||
| } | |||
| Fail(t, fmt.Sprintf("Should be empty, but was %v", object), msgAndArgs...) | |||
| Fail(t, fmt.Sprintf("Should be empty, but isn't %v", object), msgAndArgs...) | |||
There was a problem hiding this comment.
The message shows the unexpected value. is is ok.
Suggested change
| Fail(t, fmt.Sprintf("Should be empty, but isn't %v", object), msgAndArgs...) | |
| Fail(t, fmt.Sprintf("Should be empty, but is %v", object), msgAndArgs...) |
|
The problem you see in the original message is not obvious to me. Could you explain with more details what you find confusing in that message and how you are solving the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The message returned by
Empty()is a bit confusing because it states the following:Should be empty, but was [1, 2].Changes
assert.Empty()assert.NotEmpty()Testcase
https://go.dev/play/p/Rx_KYuAQe2J