Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: object formatting in Len message #1405

Closed
wants to merge 1 commit into from
Closed

fix: object formatting in Len message #1405

wants to merge 1 commit into from

Conversation

rprtr258
Copy link

@rprtr258 rprtr258 commented Jun 22, 2023 •
edited

Summary

Changes

Change formatting in Len method from %s to spew.Dump

Motivation

Old code prints:

Error: "map[@errors:[def] @message:abc field1:%!s(int=1) field2:2 field3:%!s(float64=3.3)]" should have 6 item(s), but has 5

which contains invalid formatting %!s(int=1)

Related issues

@dolmen dolmen added the pkg-assert Change related to package testify/assert label Jul 6, 2023
@rprtr258 rprtr258 requested a review from alexandear July 11, 2023 11:53
@rprtr258 rprtr258 changed the title master: fix object formatting in Len message fix: object formatting in Len message Jul 21, 2023
@dolmen dolmen mentioned this pull request Oct 16, 2023
Merged
alexandear
alexandear suggested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we need to extend tests for the fixes?

@rprtr258 rprtr258 closed this by deleting the head repository Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandear alexandear alexandear requested changes

Assignees
No one assigned
Labels
enhancement pkg-assert Change related to package testify/assert
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rprtr258 @alexandear @dolmen