chore: remove refs to deprecated io/ioutil #1407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
SuperQ
approved these changes
Jul 5, 2023
|
I think that So I think we must block this for now. |
|
We already have this problem by using Go modules (1.13), as well as specifying a minimum Go version in the I haven't done an exhaustive search, but I'm guessing there are already features in use that make this unusable in older versions. |
|
The CI tests are updated, so a rebase should show this is safe. |
dolmen
added
internal/refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
"io/ioutil" has been deprecated since Go 1.19: As of Go 1.16
Changes
Motivation
remove refs to deprecated io/ioutil
Related issues