Allow tests to fail on master #623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #620 fixes this issue. |
|
I would still like to see this merged, as it prevents future problems with go:master |
|
Any update? |
|
@georgelesica-wf We can close this PR. |
|
@hanzei Thought we could close this, since the latest PR's are passing in CI, and we don't need allow failures, if you still think there're reasons to do so, please share it, and we can reopen it and discuss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing against go tip we can allow tests to fail. This PR also ensures that we run test against the newest go version e.g.
1.10.3instead of1.10Ref #619