Switch codegen to source importing and allow additional imports. #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can change this to use imported.ForCompiler() if you like, but that was only introduced in 1.12 |
nomis52
changed the title
Go 1.5 introduced the 'source' compiler. See golang/go#11415 for details. This avoids the problem of using out of date information when generating code. It also means we don't have to have to run `go install` prior to generating. I also added the ability to specify additional imports since we use codegen to generate files that depend on types outside testify.
|
@nomis52 This PR doesn't seem relevant anymore after rebase. Could you either confirm (and close) or explain how it is still useful? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.5 introduced the 'source' compiler. See
golang/go#11415 for details.
This avoids the problem of using out of date information when generating
code. It also means we don't have to have to run
go installprior togenerating.
I also added the ability to specify additional imports since we use
codegen to generate files that depend on types outside testify.