Clean up code generation and CI process #760
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgelesica-wf
force-pushed
the
fix-generation
branch
from
6c49db9
to
6212fa5
Compare
georgelesica-wf
force-pushed
the
fix-generation
branch
from
2287e28
to
cb27f83
Compare
georgelesica-wf
changed the title
|
@georgelesica-wf some of the changes in the PR are not relevant anymore due to us dropping Go 1.9 support. Would you like to rebase and I'd be happy to review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm really not sure if this is a good idea or not, but it seems to fix the code generation issues we've seen in a few PRs.
I've also tidied up some of the CI stuff to make it easier to debug.