Sourcery refactored main branch

[sourcery-ai]

Branch main refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch origin sourcery/main
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Lines 13-63 refactored with the following changes:

• Replace call to format with f-string [×3] (use-fstring-for-formatting)
• Use f-string instead of string concatenation [×5] (use-fstring-for-concatenation)

[sourcery-ai]

Function add_scheme_and_domain refactored with the following changes:

• Replace if statement with if expression (assign-if-exp)

[sourcery-ai]

PR Type: Refactoring

Summary of PR: This PR introduces refactoring changes made by Sourcery, an automated code review and refactoring tool, to the main branch of the repository. The changes include the use of f-strings for string formatting, simplification of conditional statements, and restructuring of list and dictionary comprehensions.

General PR suggestions

• Ensure that the use of f-strings in exception messages does not lead to unnecessary expression evaluations. Traditional string formatting with lazy evaluation might be more appropriate in some cases.
• Be cautious with the use of f-strings in regular expressions, especially when dealing with strings that may contain regex metacharacters. Proper escaping is necessary to avoid potential bugs.
• Consider the readability of one-liner conditional statements. In some cases, the original multi-line if-else blocks may be more readable and maintainable.
• When using methods like cfg.get to provide default values, ensure that the defaults are appropriate for the application's requirements and won't lead to unexpected behavior.
• Review the changes for consistency and adherence to the project's coding standards, as automated refactoring tools may not always align with project-specific guidelines.

Your trial expires on December 14, 2023. Please email tim@sourcery.ai to continue using Sourcery ✨

[sourcery-ai]

suggestion (llm): Using f-strings for exceptions is not recommended as it can lead to the evaluation of expressions that might not be needed if the assertion does not fail. Consider using the traditional formatting which evaluates lazily.

Suggested change

	assert o in cfg, f"missing expected setting: {o}"
	assert o in cfg, "missing expected setting: %s" % o

[sourcery-ai]

issue (llm): The refactored regular expression replacement using f-strings may introduce a bug if 'ext' contains special regex characters. Ensure that 'ext' is properly escaped if it's expected to contain regex metacharacters.

[sourcery-ai]

suggestion (llm): The refactored one-liner for URL concatenation is less readable than the original if-else block. Consider reverting to the original block or using a more readable approach.

Suggested change

	return base_url + partial_url if partial_url[0] == "/" else partial_url
	- return base_url + partial_url if partial_url[0] == "/" else partial_url

[sourcery-ai]

thought (llm): The change to use 'cfg.get' for 'console_scripts' is good for handling missing keys, but ensure that the default empty string is an appropriate fallback for your application's needs.