Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instantiate distinct phantomJS servers to allow async wallaby tests for real-time features #13

Closed
vanderhoop opened this issue Jan 29, 2017 · 2 comments
Closed

instantiate distinct phantomJS servers to allow async wallaby tests for real-time features #13

vanderhoop opened this issue Jan 29, 2017 · 2 comments
Labels
help wanted

Comments

@vanderhoop
Copy link
Contributor

see message from 0a48f5c
@vanderhoop
Copy link
Contributor Author

not sure this is necessary. at the moment, there is only one "room", so all of the tests are visiting the same room concurrently (when the IntegrationCase tests are set to async: true, which currently, they are not). This problem will solve itself once we give each retro (and thus, each integration test) its own UUID. Then, when a retro is generated within the test, the other user just visits /retro/<SOME_UUID>, and the other tests will have their own room.

@vanderhoop vanderhoop mentioned this issue Feb 3, 2017
Closed
2 tasks
@vanderhoop
Copy link
Contributor Author

this issue was made null-and-void by e3fab0b. closing!

vanderhoop added a commit that referenced this issue Feb 16, 2019
@vanderhoop
This is a squashed reversion of the following, as the experiments we …
80e93fe 
…did with native HTML5 drag and drop got to be too painful and risky.

  Revert "Improve comments in IdeaDropTarget"

  This reverts commit de6abdb.

  # This is the commit message #2:

  Revert "Add centered 'linkify' icon on ideas when hovered over in the grouping stage"

  This reverts commit 574158f.

  # This is the commit message #3:

  Revert "Optimization: throttle invocations of handleDragOver's state updates"

  This reverts commit 586f57b.

  # This is the commit message #4:

  Revert "Lint"

  This reverts commit c3ba534.

  # This is the commit message #5:

  Revert "Bugfix: only direct descendants of .dragged-over get overlay styling applied"

  This reverts commit 03dd760.

  # This is the commit message #6:

  Revert "Only enable an 'idea' as a drop target in Grouping Stage"

  This reverts commit 721040b.

  # This is the commit message #7:

  Revert "Leverage IdeaDropTarget in Idea component"

  This reverts commit 18cb296.

  # This is the commit message #8:

  Revert "Extend IdeaDropTarget to allow custom tagName"

  This reverts commit 64f3c35.

  # This is the commit message #9:

  Revert "Disable CategoryColumn drag and drop handlers when not in idea generation"

  This reverts commit 570ac29.

  # This is the commit message #10:

  Revert "Add switch prop for activating/de-activating Idea 'drop' functionality on IdeaDropTarget"

  This reverts commit 75e949f.

  # This is the commit message #11:

  Revert "Refactor: extract drop target handlers and drop styling into component"

  This reverts commit 458f839.

  # This is the commit message #12:

  Revert "Allow any users to drag ideas in 'grouping' stage on desktop"

  This reverts commit 2bf4c6f.

  # This is the commit message #13:

  Revert "Revert "Lint""

  This reverts commit e357038e03eb2414c43837f2c6e6e63288002c62.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vanderhoop