Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a helper class for simple image processing #57

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

dotlogix
Copy link
Contributor

Hey there I just created this simple image processing class.
It is not feature complete but could be a nice addition to the toolkit.

May need additional documentation similar to what I did for the MeshBuilder?

@VaclavElias
Copy link
Collaborator

Will there be any example how to use it? Maybe, in the manual section? 🙂

@dotlogix
Copy link
Contributor Author

Yes I plan to add a full manual same as my last PR just don't have time I can mark this PR also as a draft for now.

@dotlogix dotlogix marked this pull request as draft October 19, 2023 22:43
@VaclavElias
Copy link
Collaborator

We can merge it, no problem. It is up to you :) Thanks again for more utilities for devs!

@VaclavElias VaclavElias added enhancement New feature or request rendering new-feature Makes the pull request to appear in "New Features" section of the next release note labels Oct 19, 2023
@dotlogix
Copy link
Contributor Author

So I added a LOT of functionality to this class. Also added a very detailed documentation about all abilities and also added a UI example.
Took me a while to complete.

Unfortunately we can not merge this as it is dependant on my first PR to the actual stride repo currently wait's for approval.
stride3d/stride#1972

Which adds support for image effect scissoring to support this class at all 💪

@VaclavElias
Copy link
Collaborator

Thank you @dotlogix. That's ok, we can wait. I had to do also some tiny PR's to the engine a year ago, so the code only can work 🙂. Sometimes, small PR's to the engine allow big features in the toolkit 🙂

@dotlogix dotlogix reopened this Dec 21, 2023
@dotlogix dotlogix marked this pull request as ready for review December 21, 2023 16:41
@dotlogix
Copy link
Contributor Author

Hey there @VaclavElias I think we can merge this now :) seems my change finally made it in a new nuget package

game.Run(context);
return;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed?

@VaclavElias
Copy link
Collaborator

Welcome back :)

@VaclavElias VaclavElias merged commit 140e331 into stride3d:main Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new-feature Makes the pull request to appear in "New Features" section of the next release note rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants