Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gold Image Testing Epic #15

Open
xen2 opened this issue Aug 3, 2018 · 1 comment
Open

Gold Image Testing Epic #15

xen2 opened this issue Aug 3, 2018 · 1 comment
Labels
area-Graphics enhancement New feature or request Epic Epic are defined on ZenHub side, but label also exists for easier visibility with GitHub

Comments

@xen2
Copy link
Member

xen2 commented Aug 3, 2018

We used to have a central server containing gold images to have some graphics unit tests run again.

Now being opensource, this is quite impractical:

  • Difficult to setup (not good, we want people to easily run tests by themselves)
  • Would need lot of additional work (server was really rudimentary and working with file shares)
  • Security issues (if we give access to this server, who are we allowing to update gold?)
  • Hardware differences (we can't expect pixel perfect matches)
  • Since images are stored externally, it has to be versioned manually and can easily conflict in case of merges.

The idea is now to commit those images as part of the repository, thus requiring no further setup.
Tests will be allowed to have small differences (due to GPU differences).

This work is partially started but still need further work (allow small differences, make it work on all platforms, etc...)

@Kryptos-FR
Copy link
Member

This images could also be compiled into resources in a NuGet package that test projects can reference.

@xen2 xen2 added the Epic Epic are defined on ZenHub side, but label also exists for easier visibility with GitHub label Aug 4, 2018
@Eideren Eideren added area-Graphics enhancement New feature or request labels Apr 28, 2020
Doprez referenced this issue in Doprez/stride Apr 6, 2024
Eideren pushed a commit to Eideren/xenko that referenced this issue Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Graphics enhancement New feature or request Epic Epic are defined on ZenHub side, but label also exists for easier visibility with GitHub
Projects
None yet
Development

No branches or pull requests

3 participants