Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed constructors in CsharpBeginner template #1618

Merged
merged 1 commit into from Feb 25, 2023

Conversation

Doprez
Copy link
Contributor

@Doprez Doprez commented Feb 24, 2023

PR Details

an issue was found in the beginner csharp tutorial template. This PR should resolve the issue as it seems the Constructor may have changed its formatting in a previous release.

Description

I only had to switch the location of the values in the constructor at the below locations:
InstantiatingPrefabsDemo line 28
LoadingContentDemo.cs line 71

Related Issue

#1617

Motivation and Context

makes sure new users can load the beginner templates without having to fix issues.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manio143 manio143 merged commit fad834e into stride3d:master Feb 25, 2023
@Eideren Eideren mentioned this pull request Sep 14, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants