Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reflection] Fixes loading of mixed mode assemblies in .NET Core #1691

Merged

Conversation

azeno
Copy link
Collaborator

@azeno azeno commented Jun 13, 2023

PR Details

Description

It seems .NET Core behaves slightly different in this regard, throwing a different kind of exception, so previous code no longer applies, even though it's the same assembly being loaded (irrKlang.NET4.dll)

Related Issue

#1072

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

It seems .NET Core behaves slightly different in this regard, throwing a different kind of exception, so previous code no longer applies, even though it's the same assembly being loaded (irrKlang.NET4.dll)
@Eideren Eideren merged commit dcc7793 into stride3d:master Jun 19, 2023
5 of 15 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Jun 19, 2023

Thanks !

@azeno azeno deleted the dev/azeno/mixed-mode-assembly-load-fix-2 branch June 21, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants