Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations fix #1717

Merged
merged 1 commit into from Sep 28, 2023
Merged

Translations fix #1717

merged 1 commit into from Sep 28, 2023

Conversation

Jklawreszuk
Copy link
Collaborator

@Jklawreszuk Jklawreszuk commented Jul 21, 2023

PR Details

Description

PR fixes translations by using dlls and updated code from my gettext fork : https://github.com/Jklawreszuk/gettextnet.

image

Additional context

Although, It works correct and imho it could be merged I would say that is only temporary fix.
There are couple things need to do in the future:

  • Merge PR: Migration NET6+ and more gettextnet#2
    • Publish nuget packages: GNU.Getopt, GNU.Gettext
    • optional: Publish nuget tools: GNU.Gettext.Msgfmt nad GNU.Gettext.Xgettext
      • Remove unnecessary dlls in deps/gettext.net folder
      • Update teamcity pipeline or force to install required dotnet tools through msbuild if missing
    • Consume packages in Stride repo

Related Issue

#1714

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Doprez
Copy link
Contributor

Doprez commented Sep 16, 2023

Is this PR large because of the additon of the GNU.Gettext dependancies? if we were to merge your other PR would that shrink this down?

@Jklawreszuk
Copy link
Collaborator Author

@Doprez Exactly, I've added so many files as a temp fix, because @xen2 has to review and release nuget packages. Other that that I think it will affect around 3 files 🙂

@Eideren Eideren added this to the 4.2 milestone Sep 26, 2023
@Jklawreszuk
Copy link
Collaborator Author

Alright, so I've reduced the size of the commit and It's finally ready for review 👌

@Eideren
Copy link
Collaborator

Eideren commented Sep 28, 2023

Works great, thanks !

@Eideren Eideren merged commit da514b6 into stride3d:master Sep 28, 2023
1 check passed
@Jklawreszuk Jklawreszuk deleted the translations-fix branch September 28, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants