Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Add new Theme & UI fixes/refinements #1807

Merged
merged 10 commits into from Sep 24, 2023

Conversation

SVNMLR
Copy link
Contributor

@SVNMLR SVNMLR commented Sep 20, 2023

PR Details

  • New: Add "Divided" Theme -> Inspired after "Unity"'s UI ;)

  • Fix: Change some colors of the light theme, for better readybility

  • Change: Use WindowBackgroundColor from Themes for bottom StatusBar

  • Change: Use small GridSeperator as a line to better seperate columns visually in PropertyGrid

  • Change: Use dynamic colors for Debug-Buttons (same as the debug text printed in log) from the Theme, instead of just white

  • Change: Reduce the size of some Icons

  • Change: Improve Arrow Icon geometry

  • Change: Add small corner radius to some elements

  • Change: Make Component Headers slightly smaller

  • Change: TextColor of Prefab-Text & LinkText in SceneView-Hierarchy to new dynamic variables from Themes -> add new variables

  • Change: Use ComboBox Background instead of NormalBrush Color for CheckBox Background

Description

This PR contains a new Theme inspired by Unitys UI conventions and includes some small UI improvements and fixes.
Further details under motivation.

Related Issue

none

Motivation and Context

I wanted to have the UI looking more after Unitys Dark Theme, cause I find it very appealing and minimalistic.
On top of that I think it is good to give users coming from Unity the opportunity to recognize UI-Elememts faster and feel "home".

Despite the new Theme I have found some small UI bugs and spotted here and there possibilities to improve the look a little bit.

Further I have read some comments in Discord, that some people have problems recognizing the Gridseperator in the Property Grid, so I have made it visible,
to better communicate the possibility of dragging it.

Due to the planned switch to avalonia, I have only changed small things, to not waste too much time on that.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

* Change: Use dynamic colors (same as the text printed in log) from Theme instead of just a white icon
* New: Add Divided Theme -> Inspired after Unity UI
* Change: TextColor of Prefab-Text to blueish tint -> add new variable
* Change: Make plus Icon slightly smaller
* Change: Make Arrows for folding (hierarchy, Properties ..) slightly smaller
* Change: IMprove Arrow Icon geometry
* Change: Use ComboBox Background instead of NormalBrush Color for CheckBox Background
* Change: Revert changes in csproj
* Change: Add missing variables to Themes
* Change: Add small corner radius to some elements
* Change: Make Component Headers slightly smaller
* Change: Use colored Icons for Asset Debug Buttons
* Fix: Change Colors of Light Theme, for better readybility
* Change: Use small GridSeperator as line to better seperate columns in PropertyGrid
* Change: Reduce the size of some Icons
@Doprez
Copy link
Contributor

Doprez commented Sep 20, 2023

Could you share a screen shot in the comments?

@IXLLEGACYIXL
Copy link
Collaborator

could you have a look at this issue? its a bug in the light theme
#1661
or does your fix allready cover that?

@SVNMLR
Copy link
Contributor Author

SVNMLR commented Sep 20, 2023

No Problem

This is the new Divided Theme :)

grafik

@IXLLEGACYIXL
Copy link
Collaborator

No Problem

This is the new Divided Theme :)

grafik

this looks awesome!

@SVNMLR
Copy link
Contributor Author

SVNMLR commented Sep 20, 2023

could you have a look at this issue? its a bug in the light theme #1661 or does your fix allready cover that?

No, I havent't seen that.
I will look into it and check the LightTheme after some more bugs and will try to fix them :)

@IXLLEGACYIXL
Copy link
Collaborator

could you have a look at this issue? its a bug in the light theme #1661 or does your fix allready cover that?

No, I havent't seen that. I will look into it and check the LightTheme after some more bugs and will try to fix them :)

if you are still working on it you could add WIP to the title so its blocked for merging

@SVNMLR SVNMLR changed the title [Editor] Add new Theme & UI fixes/refinements [WIP] [Editor] Add new Theme & UI fixes/refinements Sep 20, 2023
@tebjan
Copy link
Member

tebjan commented Sep 22, 2023

If it is WIP the correct way to make that is by pressing "convert to draft":
image

@tebjan
Copy link
Member

tebjan commented Sep 22, 2023

Really cool PR, btw... :)

SVNMLR and others added 2 commits September 22, 2023 13:07
* Fix: Use a darker WindowBackgroundBrush Color -> Fixes ToolTips having white as TextColor & BackgroundColor if an Entity is selected in MainScene Hierarchy (stride3d#1661)
* Change: Slightly optimize colors of the Light Theme for better readability in some cases
* Change: Use a variable for the Status Bar Color, to be able to use a different one, depending on the active Theme
@SVNMLR SVNMLR marked this pull request as draft September 22, 2023 11:25
* Change: Give the asset status indicator some small margin & make it slightly smaller
* Change: Some Buttons now have a small CornerRadius to improve visuals
@SVNMLR
Copy link
Contributor Author

SVNMLR commented Sep 22, 2023

Here are some Screenshots of the changes and the fix in the Light Theme I have made :)

UIChanges

@SVNMLR SVNMLR changed the title [WIP] [Editor] Add new Theme & UI fixes/refinements [Editor] Add new Theme & UI fixes/refinements Sep 22, 2023
@SVNMLR SVNMLR marked this pull request as ready for review September 22, 2023 12:24
@IXLLEGACYIXL
Copy link
Collaborator

there is also somewhere a -77 in a xaml which spams te editor with errors, im not sure where it is anymore as i looked at it a month ago

@SVNMLR
Copy link
Contributor Author

SVNMLR commented Sep 22, 2023

So far I am ready now.

I hope this is all fine and you all can use this :)

I have made a fix for the #1661 The TextColor and Background color where both white.

@SVNMLR
Copy link
Contributor Author

SVNMLR commented Sep 22, 2023

there is also somewhere a -77 in a xaml which spams te editor with errors, im not sure where it is anymore as i looked at it a month ago

I don't really understand you. What do you mean?

@IXLLEGACYIXL
Copy link
Collaborator

there is also somewhere a -77 in a xaml which spams te editor with errors, im not sure where it is anymore as i looked at it a month ago

I don't really understand you. What do you mean?

hold on , eideren mentioned it today, thats why i remember it

https://discord.com/channels/500285081265635328/1154729275191197728/1154729278781526087

@SVNMLR
Copy link
Contributor Author

SVNMLR commented Sep 22, 2023

there is also somewhere a -77 in a xaml which spams te editor with errors, im not sure where it is anymore as i looked at it a month ago

I don't really understand you. What do you mean?

hold on , eideren mentioned it today, thats why i remember it

https://discord.com/channels/500285081265635328/1154729275191197728/1154729278781526087

You mean i should change the value as mentioned in Discord, in ths PR, too?

@Doprez
Copy link
Contributor

Doprez commented Sep 22, 2023

there is also somewhere a -77 in a xaml which spams te editor with errors, im not sure where it is anymore as i looked at it a month ago

I don't really understand you. What do you mean?

hold on , eideren mentioned it today, thats why i remember it
https://discord.com/channels/500285081265635328/1154729275191197728/1154729278781526087

You mean i should change the value as mentioned in Discord, in ths PR, too?

I think @Eideren was trying to get confirmation on why this was made this way. Depending on the time needed to wait for confirmation I think this PR is good as is.

I want this to be merged so I can use it lol

@Eideren
Copy link
Collaborator

Eideren commented Sep 24, 2023

I think we can merge it while D3ZAX gets back to me, is this PR ready @SVNMLR ?

@SVNMLR
Copy link
Contributor Author

SVNMLR commented Sep 24, 2023

I think we can merge it while D3ZAX gets back to me, is this PR ready @SVNMLR ?

Yes, I'm ready and haven't got anything to add here :)

@Eideren Eideren merged commit 7020dcd into stride3d:master Sep 24, 2023
1 check passed
@Eideren
Copy link
Collaborator

Eideren commented Sep 24, 2023

Thanks @SVNMLR !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants