Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension): Rename Extension installer buttons for clarity #1862

Closed
wants to merge 0 commits into from

Conversation

acastrodev
Copy link
Contributor

@acastrodev acastrodev commented Sep 28, 2023

PR Details

  • Update launcher extension button labels
  • New labels: "Visual Studio Shader {0} Extensions"
  • Add link under VisualStudioExtension label: "An installed Visual Studio is required, which can be found here"

Description

This commit addresses the issue of misleading launcher extension button labels, making it clearer that users are installing an extension, not the IDE itself. The new labels and added clarification help redirect users to the Visual Studio download page to avoid confusion.

Related Issue

Resolves: #1773

Motivation and Context

Improves Launcher UX
image

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Doprez
Copy link
Contributor

Doprez commented Sep 28, 2023

did you add the link under "here"? It doesnt seem highlighted in the screenshot.

@acastrodev
Copy link
Contributor Author

did you add the link under "here"? It doesnt seem highlighted in the screenshot.

I added "An installed Visual Studio is required, which can be found here" entirely

@Doprez
Copy link
Contributor

Doprez commented Sep 28, 2023

did you add the link under "here"? It doesnt seem highlighted in the screenshot.

I added "An installed Visual Studio is required, which can be found here" entirely

Right, but is "Which can be found here" referring to the extension or the full IDE?

@acastrodev
Copy link
Contributor Author

did you add the link under "here"? It doesnt seem highlighted in the screenshot.

I added "An installed Visual Studio is required, which can be found here" entirely

Right, but is "Which can be found here" referring to the extension or the full IDE?

To the full IDE, also added the link tooltip:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Tool download buttons in launcher.
2 participants