Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Exception Caused By Privacy Policy URL in Crash Reporter #1878

Merged
merged 1 commit into from Oct 3, 2023

Conversation

MeharDT
Copy link
Contributor

@MeharDT MeharDT commented Oct 2, 2023

PR Details

Clicking the Privacy Policy link in the Crash Reporter will generate an exception.

Description

The Process requires shell execute to be enabled, this was the default setting in .NET Framework but is no longer the case with .NET Core.

This PR can be tested by adding the following to Main() in Stride.GameStudio/Program.cs,

            try
            {
                throw new Exception("Test");
            }
            catch (Exception ex)
            {
                HandleException(ex, 0);
            }

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Fixed exception generated by Crash Reporter when clicking Privacy Policy link
@MeharDT
Copy link
Contributor Author

MeharDT commented Oct 2, 2023

Unrelated but the Crash Reporter form still uses Xenko images, I wasn't able to find the correct .xaml file in the solution to fix it.

@Eideren Eideren merged commit 025e30d into stride3d:master Oct 3, 2023
1 check passed
@Eideren
Copy link
Collaborator

Eideren commented Oct 3, 2023

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants