Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Launcher] Prevent launcher automatically closing when offline #1912

Merged
merged 1 commit into from Oct 10, 2023

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented Oct 8, 2023

PR Details

To be honest, I don't even know it should automatically close when the update process fails, it should just let the user know and still give the user the ability to launch the gamestudio ...

Related Issue

None reported

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Eideren Eideren merged commit b709d58 into stride3d:master Oct 10, 2023
11 of 14 checks passed
@Eideren Eideren deleted the launcher_noconnection branch October 10, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants