Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Fixed an errors in the build pipeline associated with having a space in the user name #1941

Merged
merged 3 commits into from Oct 15, 2023

Conversation

Fydar
Copy link
Contributor

@Fydar Fydar commented Oct 15, 2023

PR Details

A fix of #1939, fixing all issues I encountered when building Stride.Core.AssemblyProcessor and the errors in Stride.sln when generating satellite assemblies (the localization assemblies).

Description

Adding " to the .csproj file commands that are failing due to spaces in the user name.

Related Issue

Motivation and Context

I am unable to contribute to the project since it can't build on my machine, which happens to have a space in the user name until issue #1939 is fixed, so I'm working through fixing it.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Eideren
Copy link
Collaborator

Eideren commented Oct 15, 2023

The changes overlap those in #1904, although that one doesn't quote around ILRepack - maybe it's best to close this one and leave a comment over in that PR if that change is necessary ?

@Ethereal77
Copy link
Contributor

Noted and done in #1904

A part of my effort to make the build pipeline work on my user which has a username with a space in it (stride3d#1939).
@Fydar Fydar changed the title [Build] Fixed an exit code 9009 encountered during the build pipeline [Build] Fixed an errors in the build pipeline associated with having a space in the user name Oct 15, 2023
@Fydar
Copy link
Contributor Author

Fydar commented Oct 15, 2023

Awesome! I've added changes to the pull request and renamed it to reflect the final changes required for the build to work on a system with a space in the username.

@Eideren Eideren merged commit cbb7ed7 into stride3d:master Oct 15, 2023
1 check passed
@Eideren
Copy link
Collaborator

Eideren commented Oct 15, 2023

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants