Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Fix Android build error #1949

Merged
merged 1 commit into from Oct 16, 2023
Merged

Conversation

froce
Copy link
Collaborator

@froce froce commented Oct 16, 2023

PR Details

Fixes the broken Android build. (#1788 (comment))

Description

Missed using statements in files that only gets built for Android.

Related Issue

Motivation and Context

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@froce
Copy link
Collaborator Author

froce commented Oct 16, 2023

That should be all that was missing.

@xen2 - seems like teamcity builds are not automatically running for contributors?

@xen2
Copy link
Member

xen2 commented Oct 16, 2023

Yes, let me look into it, thanks!

@xen2
Copy link
Member

xen2 commented Oct 16, 2023

OK, it seems the Contributor tag you have just means you submitted PR in the past.
Let me invite you as an external collaborator which is what is needed.

@Eideren
Copy link
Collaborator

Eideren commented Oct 16, 2023

The Simple test always fails right now, so looks like everything's working as expected, can I merge this in now @froce ?

@froce
Copy link
Collaborator Author

froce commented Oct 16, 2023

Yes, this can be merged.

@Eideren Eideren merged commit db628f4 into stride3d:master Oct 16, 2023
12 of 14 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Oct 16, 2023

Thanks @froce :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants